This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] tests: move -D_FORTIFY_SOURCE to CPPFLAGS

From: Mike Frysinger <vapier at gentoo dot org>
To: "Carlos O'Donell" <carlos at systemhalted dot org>
Cc: libc-alpha at sourceware dot org
Date: Mon, 7 May 2012 20:05:00 -0400
Subject: Re: [PATCH] tests: move -D_FORTIFY_SOURCE to CPPFLAGS
References: <1336344661-26623-1-git-send-email-vapier@gentoo.org> <201205070055.40012.vapier@gentoo.org> <CADZpyizr2BxNRc6NDdfXxn5vF4mV7eR=VY7S0tBEn5wYVYnM_g@mail.gmail.com>

On Monday 07 May 2012 10:00:30 Carlos O'Donell wrote:
> I'm OK with this patch provided you include a comment in
> debug/Makefile stating why you can't just use CFLAGS.

ok

> Doesn't this effect *every* test that adds their own test-specific flags?

yes, but i just picked the places where this matters in practice (at least, to 
me).  the other -D flags are much more unlikely to get trumped by the user's 
settings.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Follow-Ups:
- Re: [PATCH] tests: move -D_FORTIFY_SOURCE to CPPFLAGS
  - From: Carlos O'Donell

References:
- [PATCH] tests: move -D_FORTIFY_SOURCE to CPPFLAGS
  - From: Mike Frysinger
- Re: [PATCH] tests: move -D_FORTIFY_SOURCE to CPPFLAGS
  - From: Mike Frysinger
- Re: [PATCH] tests: move -D_FORTIFY_SOURCE to CPPFLAGS
  - From: Carlos O'Donell

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]