This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Sign extend relocation result to 64bit forR_X86_64_DTPOFF64/R_X86_64_TPOFF64
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: "H.J. Lu" <hjl dot tools at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 8 May 2012 10:10:44 -0700 (PDT)
- Subject: Re: PATCH: Sign extend relocation result to 64bit forR_X86_64_DTPOFF64/R_X86_64_TPOFF64
- References: <20120508164809.GA31918@intel.com><20120508165735.GG19535@redhat.com>
> On Tue, May 08, 2012 at 09:48:09AM -0700, H.J. Lu wrote:
> > +# ifdef __ILP32__
> > + *(Elf64_Sxword *) reloc_addr
> > + = (Elf64_Sxword)
> > + ((Elf32_Sword) (sym->st_value + reloc->r_addend));
> > +# else
>
> The usual style is to keep the = at the end of the line.
No, it's not. GNU style puts the operator on the next line, even the
assignment operator.