This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] #13594: Avoid race in nscd


> This is the same code as used in nscd/nscd_helper.c.

Ok.  It would be better to write a shared subroutine for it.
But that doesn't have to hold up this change.

> +    retval =  map->head->extra_data[NSCD_HST_IDX_CONF_TIMESTAMP];

Excess space here.

Fine to commit with that one nit fix.  If you want to break out the locking
loop into a subroutine first, I'd like that even better.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]