Re: PATCH: Update sysdeps/x86_64/start.S for x32.

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, May 14, 2012 at 3:34 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> - ? ? ? ? ? ? 0(%rsp) ? ? ? ? ? ? ? ? argc
>> - ? ? ? ? ? ? 8(%rsp) ? ? ? ? ? ? ? ? argv[0]
>> + ? ? ? ? ? ? 0(%rsp) ? ? ? ? ? ? ? ? ? ? ? ? argc
>> + ? ? ? ? ? ? LP_SIZE(%rsp) ? ? ? ? ? ? ? ? ? argv[0]
>> ? ? ? ? ? ? ? ...
>> - ? ? ? ? ? ? (8*argc)(%rsp) ? ? ? ? ?NULL
>> - ? ? ? ? ? ? (8*(argc+1))(%rsp) ? ? ?envp[0]
>> + ? ? ? ? ? ? (LP_SIZE*argc)(%rsp) ? ? ? ? ? ?NULL
>> + ? ? ? ? ? ? (LP_SIZE*(argc+1))(%rsp) ? ? ? ?envp[0]
>> ? ? ? ? ? ? ? ...
>> - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? NULL
>> + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? NULL
>
> Fix the indentation (i.e. delete a tab) so the rhs lines up as before.

Is this how it shows up in diff.  I am also enclosing the patched file.

>> +#ifdef __ILP32__
>> + ? ? mov (%rsp),%esi ? ? ? ? /* Simulate popping 4byte argument count. ?*/
>> + ? ? addl $4,%esp
>> +#else
>
> Space after comma. ?Why use "addl" when the trend is to drop the size
> suffices everywhere they are superfluous?
>

Here is the updated patch with add.

Thanks.

-- 
H.J.

Attachment: 0039-Simulate-popping-4byte-argument-count-for-x32.patch
Description: Binary data

Attachment: start.S
Description: Binary data