This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Use R*_LP, sizeSS, oSS_FLAGS, oSS_SP and oSS_SIZE

From: Roland McGrath <roland at hack dot frob dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Tue, 15 May 2012 16:37:05 -0700 (PDT)
Subject: Re: PATCH: Use R*_LP, sizeSS, oSS_FLAGS, oSS_SP and oSS_SIZE
References: <20120515230625.GA26807@intel.com><20120515230924.066D62C0A3@topped-with-meat.com><CAMe9rOom-U4-LBLkUQCJoiHXJNwcELF75Gn9pGS-K3XZ5eEW=Q@mail.gmail.com>

> 	* sysdeps/unix/sysv/linux/x86_64/Makefile (gen-as-const-headers):
> 	Add sigaltstack.sym.
> 
> 	* sysdeps/unix/sysv/linux/x86_64/____longjmp_chk.S: Include
> 	"sigaltstack.h".
> 	(CALL_FAIL): Use RSP_LP to operate on stack.  Use RDI_LP on
> 	longjmp_msg pointer.
> 	(____longjmp_chk): Use R8_LP and RDX_LP on SP and PC.  Use
> 	R*_LP, sizeSS, oSS_FLAGS, oSS_SP and oSS_SIZE for alternate
> 	signal stack.
> 
> 	* sysdeps/unix/sysv/linux/x86_64/sigaltstack.sym: New.

Fix the all file names here.  This is all one paragraph (no blank lines in
between) since it's all a single change.

Use #include <> to be consistent with uses of other generated headers.

With those fixes, the change is OK.


Thanks,
Roland

References:
- PATCH: Use R*_LP, sizeSS, oSS_FLAGS, oSS_SP and oSS_SIZE
  - From: H.J. Lu
- Re: PATCH: Use R*_LP, sizeSS, oSS_FLAGS, oSS_SP and oSS_SIZE
  - From: Roland McGrath
- Re: PATCH: Use R*_LP, sizeSS, oSS_FLAGS, oSS_SP and oSS_SIZE
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]