This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Add x86_64/bits/statfs.h

From: Roland McGrath <roland at hack dot frob dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Wed, 16 May 2012 15:27:50 -0700 (PDT)
Subject: Re: PATCH: Add x86_64/bits/statfs.h
References: <20120516194725.GA2091@intel.com><20120516200942.4A13F2C0A8@topped-with-meat.com><CAMe9rOoFOyGCsR4g8x2sHoAgWrWdFeAHgYXFG4k1Gzp77f7mRw@mail.gmail.com>

IMHO __*_TYPE never should have been used directly in struct declarations
like that.  Those fields should use some __*_t type instead.  If we have to
add a new one so it can differ appropriately for different machines, that
would be better than duplicating the file.


Thanks,
Roland

Follow-Ups:
- Re: PATCH: Add x86_64/bits/statfs.h
  - From: H.J. Lu

References:
- PATCH: Add x86_64/bits/statfs.h
  - From: H.J. Lu
- Re: PATCH: Add x86_64/bits/statfs.h
  - From: Roland McGrath
- Re: PATCH: Add x86_64/bits/statfs.h
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]