This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Update x86-64/sysdep.h

On 05/22/2012 06:19 PM, Roland McGrath wrote: 
But I'm not sure whether this change is really correct, have a look at
sysdeps/unix/sysv/linux/x86_64/sched_getcpu.S


This code is already wrong in the static case where we jump to the sysdep.S
label.

You're right - and you convinced me that your suggestion to use the ret is the right thing.

But let's fix sched_getcpu.S first (it was the only place where I found this but I would appreciate if somebody else double checks) before this gets changed,

Andreas
--
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]