This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 9/9] Expand tabs to spaces.
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Paul Eggert <eggert at cs dot ucla dot edu>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 23 May 2012 11:41:19 -0700 (PDT)
- Subject: Re: [PATCH 9/9] Expand tabs to spaces.
- References: <4FBD1989.4040905@cs.ucla.edu>
Off hand, I think we'd prefer that you instead maintain mktime in libc and
keep it in canonical GNU style, which means tabs. Then you can break the
correct formatting in the procedure to copy it to gnulib instead of having
it be broken in libc.
Aside from config.{sub,guess}, I don't think we have any precedent for
source files that are primarily maintained elsewhere and copied into libc.
We have had precedent for the opposite direction for 20 years or so. I'm
not very comfortable with the notion of any actual code we are responsible
for being blindly copied from elsewhere without the usual sort of piecemeal
review for each change.
Thanks,
Roland