This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] tests: move -D_FORTIFY_SOURCE to CPPFLAGS
On Wed, May 30, 2012 at 11:58 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Monday 14 May 2012 01:09:43 Mike Frysinger wrote:
>> On Tuesday 08 May 2012 13:23:33 Carlos O'Donell wrote:
>> > On Tue, May 8, 2012 at 12:24 PM, Mike Frysinger wrote:
>> > > On Tuesday 08 May 2012 09:28:15 Carlos O'Donell wrote:
>> > >> On Tue, May 8, 2012 at 1:55 AM, Mike Frysinger wrote:
>> > >> > +# Need to make sure the settings here override what configure might
>> > >> > +# have set up for us, so keep the CFLAGS/CPPFLAGS split logical.
>> > >>
>> > >> It doesn't say why we put the -D_FORTIFY_SOURCE=1 in CPPFLAGS?
>> > >
>> > > the "keep the ... split logical" implies why -- -D/-I/etc... flags are
>> > > CPPFLAGS, not CFLAGS. ?this isn't unique to glibc.
>> > >
>> > >> # Need to make sure the settings here override what configure might
>> > >> # have set up for us, so use CPPFLAGS (last in the expanded list)
>> > >> # to set test flags we always want enabled.
>> > >
>> > > that makes it sound like we should be using CPPFLAGS for everything we
>> > > want to override
>> >
>> > That's not far from the truth though? :-)
>> >
>> > Any suggestion for improving it?
>>
>> # Need to make sure the settings here override what configure might have
>> # set up for us, so keep the CFLAGS/CPPFLAGS split logical as the order is:
>> # <user CFLAGS> <test CFLAGS> <user CPPFLAGS> <test CPPFLAGS>
>
> this version OK ?
> -mike
Yes, that's fine. OK to checkin.
Cheers,
Carlos.