This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 07/10] Copy i486 bits/string.h to x86_64 bits/string.h
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 4 Jun 2012 12:18:45 -0700 (PDT)
- Subject: Re: [PATCH 07/10] Copy i486 bits/string.h to x86_64 bits/string.h
- References: <20120604141710.GF17135@intel.com>
I don't think we should be duplicating so much code in two files. I
think it's the case that we effectively require i486 or newer nowadays
(i.e. no i386-*-* configurations really work). At any rate, your
change adds the #if test so that -march=i386 wouldn't use the inlines.
So I think what you should do is first make the change to the file in
place to add the #if test, and then move it to sysdeps/x86.
Thanks,
Roland