This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 07/10] Copy i486 bits/string.h to x86_64 bits/string.h


I don't think we should be duplicating so much code in two files.  I
think it's the case that we effectively require i486 or newer nowadays
(i.e. no i386-*-* configurations really work).  At any rate, your
change adds the #if test so that -march=i386 wouldn't use the inlines.
So I think what you should do is first make the change to the file in
place to add the #if test, and then move it to sysdeps/x86.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]