This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Don't bind to registered ports in bindresvport


On Friday 01 June 2012 23:03:53 Carlos O'Donell wrote:
> On Fri, Jun 1, 2012 at 4:01 PM, Dan Nicholson wrote:
> >   int nports = ENDPORT - startport + 1;
> >   int endport = ENDPORT;
> > +  bool_t chkport = TRUE;
> > +  struct servent serv;
> > +  char buf[1024];
> 
> A global static buffer of this size should come from malloc (and get
> allocated once).

eh ?  it's declared on the stack ... not sure what you mean about global or 
static.  it's pretty much the same thing as calling alloca(1024).
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]