This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Using __chk_fail from libstdc++
On Mon, 4 Jun 2012, Carlos O'Donell wrote:
> On 6/4/2012 3:51 AM, Florian Weimer wrote:
> > On 06/01/2012 10:23 PM, Roland McGrath wrote:
> >>> Perhaps it is possible to express this in a test case?
> >>
> >> Good point. It sounds to me like you or Mike just volunteered. ;-)
> >
> > It turns out that there already is a test case which checks this implicitly. I think adding a comment to it is sufficient.
> >
> > 2012-06-04 Florian Weimer <fweimer@redhat.com>
> >
> > * debug/test-strcpy_chk.c: Mention __chk_fail ABI test.
> >
>
> This looks good to me, but we are in 2.16 freeze right now.
>
> Could you please file a BZ for glibc, and add target milestone 2.17,
> that way we can check this in after the freeze.
I don't think this sort of change to a comment in a single file needs to
be delayed because of the freeze. (Delaying the ASM_GLOBAL_DIRECTIVE
change *is* appropriate, since that's a large change (with some inevitable
risk), and requires corresponding ports changes, and we want to stabilize
ports during the freeze without them needing to keep chasing a moving
target.)
--
Joseph S. Myers
joseph@codesourcery.com