This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add versions of wcscpy, wcschr, wcsrchr for power6/power7.
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: Will Schmidt <will_schmidt at vnet dot ibm dot com>
- Cc: libc-alpha at sourceware dot org, willschm at us dot ibm dot com
- Date: Fri, 15 Jun 2012 12:59:31 -0500
- Subject: Re: [PATCH] Add versions of wcscpy, wcschr, wcsrchr for power6/power7.
- References: <20120613153521.32581.21541.stgit@brimstone>
On Wed, Jun 13, 2012 at 10:35 AM, Will Schmidt
<will_schmidt@vnet.ibm.com> wrote:
> Add versions of wcscpy, wcschr, wcsrchr for power6/power7.
>
> Initially based on the versions found in wcsmbs/* ; these files
> have been changed by hand unrolling, and adding some additional
> variables to allow some read-ahead to occur, which then relieves
> some of the wait-for-increment/wait-for-load/wait-for-compare-results
> pressure that was slowing down every iteration through the while-loop.
>
> For 64-bit Power7, These changes give an approx 20% throughput boost for
> the wcschr and wcsrchr functions; and approx 40% boost for the
> wcscpy function. Â32-bit improvements appear to be slightly better
> with ~ %30 and ~ %45 respectively. ÂResults for Power6 closely match
> those for power7.
>
> Passed make check with no regressions.
>
> ---
>
> 2012-06-12 ÂWill Schmidt Â<will_schmidt@vnet.ibm.com>
>
> Â Â Â Â* powerpc32/power6/wcschr.c: New file.
> Â Â Â Â* powerpc32/power6/wcscpy.c: New file.
> Â Â Â Â* powerpc32/power6/wcsrchr.c: New file.
> Â Â Â Â* powerpc64/power6/wcschr.c: New file.
> Â Â Â Â* powerpc64/power6/wcscpy.c: New file.
> Â Â Â Â* powerpc64/power6/wcsrchr.c: New file.
Hey Will, thanks for the patch. Can you file a bugzilla under
enhancement and target it for 2.17 so that we don't forget it? We'll
address this once the 2.16 branch is baked.
Ryan