This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Fix stacksize returned for main process thread whenRLIMIT_STACK is relevant


On Tue, 19 Jun 2012 12:15:44 -0400, Carlos wrote:
> > The stacksize returned by pthread_getattr_np is incorrect if the
> > stacksize computed is based on rlimit since it should be adjusted
> > against the pages we skip above __libc_stack_end. Further, if the
> > stacksize is based on rlimit, it should be truncated to align to
> > page size because the rlimit may not necessarily be page aligned.
> 
> Have we gotten confirmation from them that this patch fixes the issue?

No confirmation from the ruby developers yet. Kosaki, could you please
verify that the patch fixes the issue you reported?
 
> > 2012-06-19  Siddhesh Poyarekar  <siddhesh@redhat.com>
> 
> As a follow-up to BZ#12416 this patch should also carry the same BZ#.

Thanks, I've fixed this in my local stash.

> Note:
> - We need some standard macros for align up and align down.
> http://sourceware.org/ml/libc-alpha/2012-04/msg00006.html

I've added this as a task here in a new Cleanup section so that one of
us can pick this up after 2.16 branches off:

http://sourceware.org/glibc/wiki/SmallProjects

> 
> Excellent test case! :-)
> 

Thanks :)

Regards,
Siddhesh


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]