This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Regenerate sysdeps/mach/configure
- From: Carlos O'Donell <carlos_odonell at mentor dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos_odonell at mentor dot com>
- Date: Thu, 21 Jun 2012 13:12:26 -0400
- Subject: Re: Regenerate sysdeps/mach/configure
- References: <Pine.LNX.4.64.1206211514540.13170@digraph.polyomino.org.uk>
On 6/21/2012 11:16 AM, Joseph S. Myers wrote:
> When I tried regenerating all configure scripts in libc with autoconf
> 2.68 (the version used for the toplevel script; problems can arise if
> the fragments use a different version from the main script) I got the
> following diffs (plus the addition of trailing blank lines in
> sysdeps/i386/configure, sysdeps/s390/s390-32/configure,
> sysdeps/s390/s390-64/configure, sysdeps/sh/configure - but the
> repository has a hook disallowing commit of such trailing blank lines
> so forcing people to edit the generated files manually before commit).
> Carlos, is this OK for master? Do you get the same diffs?
>
> 2012-06-21 Joseph Myers <joseph@codesourcery.com>
>
> * sysdeps/mach/configure: Regenerated.
>
This is OK for master.
(1) Do I see the same changes as you?
Yes.
sysdeps/i386/configure - Blank line.
sysdeps/mach/configure - Exactly the same as your changes.
sysdeps/s390/s390-32/configure - Blank line.
sysdeps/s390/s390-64/configure - Blank line.
sysdeps/sh/configure - Blank line.
I've also regenerated all of the configure files for
libc-ports and I see only differences in the file mode
e.g. from 644 to 755.
(2) Do you see the AC_LANG_SOURCE warnings introduced by 2.68?
I'm using this local patch, does it look correct?
diff --git a/configure.in b/configure.in
index 81b14c9..a19f6da 100644
--- a/configure.in
+++ b/configure.in
@@ -278,12 +278,12 @@ if test "x$systemtap" != xno; then
AC_CACHE_CHECK([for systemtap static probe support], libc_cv_sdt, [dnl
old_CFLAGS="$CFLAGS"
CFLAGS="-std=gnu99 $CFLAGS"
- AC_COMPILE_IFELSE([#include <sys/sdt.h>
+ AC_COMPILE_IFELSE([AC_LANG_SOURCE([[#include <sys/sdt.h>
void foo (int i, void *p)
{
asm ("" STAP_PROBE_ASM (foo, bar, STAP_PROBE_ASM_TEMPLATE (2)) ""
:: STAP_PROBE_ASM_OPERANDS (2, i, p));
-}], [libc_cv_sdt=yes], [libc_cv_sdt=no])
+}]])], [libc_cv_sdt=yes], [libc_cv_sdt=no])
CFLAGS="$old_CFLAGS"])
if test $libc_cv_sdt = yes; then
AC_DEFINE([USE_STAP_PROBE])
---
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026