This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [Patch] Fix another unbound alloca (BZ 13761)
- From: Carlos O'Donell <carlos_odonell at mentor dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 22 Jun 2012 16:51:52 -0400
- Subject: Re: [Patch] Fix another unbound alloca (BZ 13761)
- References: <4FE4D9C3.70703@redhat.com>
On 6/22/2012 4:46 PM, Jeff Law wrote:
> This is a follow-up to fully resolve 13761.
>
> Using the same procedures mentioned in BZ 13761, it's still possible
> to trigger an unbound alloca in nscd. Basically Siddhesh's patch
> fixed the first unbound alloca, but left a later one unfixed.
>
> Basically DATASET in cache_addgr can grow without bound in one
> particular case. When we can not permanently add the result, but can
> provide the result as-is we allocate temporary memory to hold that
> DATASET. If DATASET is large, we blow out the stack.
>
Unified diff please.
I don't even know how to read the non-unified kind, I know, young kids these days, it looks like squiggles to me :-)
http://sourceware.org/glibc/wiki/Contribution%20checklist#Proper_Formatted_Unified_diff_of_the_Changes
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026