This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Optimize strstr, strcasestr and memmem
- From: Maxim Kuvyrkov <maxim at codesourcery dot com>
- To: Carlos O'Donell <carlos_odonell at mentor dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Ryan Arnold <rsa at us dot ibm dot com>,Eric Blake <eblake at redhat dot com>
- Date: Thu, 12 Jul 2012 12:03:18 +1200
- Subject: Re: [PATCH] Optimize strstr, strcasestr and memmem
- References: <2C516CF2-D083-4C1D-AD27-6A31D381D548@codesourcery.com> <CADZpyiwSMzwbMwwmLG0Sz8RAK8ww_LH_RSt2Nd3-F8+BUDYT-w@mail.gmail.com> <0091E444-5D4A-4348-96A6-C693F9F66F1D@codesourcery.com> <4FCCD83A.9090105@mentor.com>
Carlos,
Ping.
The following patches are still pending review:
http://article.gmane.org/gmane.comp.lib.glibc.alpha/22463
http://article.gmane.org/gmane.comp.lib.glibc.alpha/22464
http://article.gmane.org/gmane.comp.lib.glibc.alpha/22465
http://article.gmane.org/gmane.comp.lib.glibc.alpha/22466
Thanks,
--
Maxim Kuvyrkov
CodeSourcery / Mentor Graphics
On 5/06/2012, at 3:46 AM, Carlos O'Donell wrote:
> On 5/30/2012 4:28 AM, Maxim Kuvyrkov wrote:
>> On 22/05/2012, at 7:49 AM, Carlos O'Donell wrote:
>>
>>> On Thu, May 17, 2012 at 5:22 PM, Maxim Kuvyrkov <maxim@codesourcery.com> wrote:
>>>> This patch optimizes strstr, strcasestr and memmem functions. This patch speeds up strstr, strcase and memmem functions with short needle inputs by more than 2 times on i686, x86_64, MIPS and other architectures.
>>
>> Carlos,
>>
>> I appreciate you reviewing the code. I've reworked the patches and will post them in separate sub-threads. Below are comments and notes on the change as a whole.
>
> Maxim,
>
> I plan to review each of these patches, but we are now into the 2.16 freeze so we can't check them in now.
>
> Could you please file a BZ (one covering all of them) for this and mark it target milestone 2.17?
>
> This way we can check these in when 2.17 is open for development at the end of the month.
>
> Cheers,
> Carlos.
> --
> Carlos O'Donell
> Mentor Graphics / CodeSourcery
> carlos_odonell@mentor.com
> carlos@codesourcery.com
> +1 (613) 963 1026