This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH,HURD] sendto: do not crash when addr is NULL
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Pino Toscano <toscano dot pino at tiscali dot it>
- Cc: libc-alpha at sourceware dot org, bug-hurd at gnu dot org
- Date: Fri, 20 Jul 2012 09:59:50 -0700 (PDT)
- Subject: Re: [PATCH,HURD] sendto: do not crash when addr is NULL
- References: <201205202258.36132.toscano.pino@tiscali.it><201206072046.11047.toscano.pino@tiscali.it><20120612171633.D5EEB2C07D@topped-with-meat.com><201206132315.13891.toscano.pino@tiscali.it>
> Hm ok, I saw other cases of shadowing by internal subroutines, and
> assumed it was okay (since inside them you want to refer to the local
> "err" instead of the outermost one.
It's not the worst thing ever, and we don't compile with -Wshadow.
But shadowing is usually a good thing to avoid just to make reading
the code easier to follow.
Thanks,
Roland