This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Take 2: Fix false positives in tst-pthread-getattr testcase
On 7/20/2012 1:55 PM, Siddhesh Poyarekar wrote:
> On Fri, 20 Jul 2012 13:36:59 -0400, Carlos wrote:
>> I would still like you to mention the possibility of a kernel bug.
>>
>> I'm also OK with URLs in comments pointing at public mailing list
>> discussions about such things. I consider the sourceware.org archives
>> to be long lived.
>
> OK, I'll commit this with the following comment to the description of
> MAX_STACK_SIZE.:
>
> +/* There is an obscure bug in the kernel due to which RLIMIT_STACK is sometimes
> + returned as unlimited when it is not, which may cause this test to fail.
> + There is also the other case where RLIMIT_STACK is intentionally set as
> + unlimited or very high, which may result in a vma that is too large and again
> + results in a test case failure. To avoid these problems, we cap the stack
> + size to one less than 8M. See the following mailing list threads for more
> + information about this problem:
> + <http://sourceware.org/ml/libc-alpha/2012-06/msg00599.html>
> + <http://sourceware.org/ml/libc-alpha/2012-06/msg00713.html>. */
>
> This test case is now about 1/3 comments :)
Wouldn't the world be a better place if test cases were all 1/3 comments?
This looks good to me.
Cheers,
Carlos.
--
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026