This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Move testsuite audit definitions to sysdeps tst-audit.h files


From: "Joseph S. Myers" <joseph@codesourcery.com>
Date: Wed, 25 Jul 2012 16:31:15 +0000

> On Wed, 25 Jul 2012, Ryan S. Arnold wrote:
> 
>> On Thu, Jul 19, 2012 at 6:57 PM, Joseph S. Myers
>> <joseph@codesourcery.com> wrote:
>> > Similar to my patch for ldsodefs.h, this patch moves the auditing
>> > definitions for testcases (tst-auditmod1.c, plus duplicate copies of
>> > the x86_64 definitions in several more x86_64-specific tests) to
>> > tst-audit.h files for libc architectures.  In the case of alpha, the
>> > libc tst-auditmod1.c still had definitions for a ports architecture -
>> > while alpha had a tst-audit.h file with four of the five required
>> > macros, so I added the missing macro there.
>> >
>> > The structure of the header files reflects that of the previous
>> > definitions in tst-auditmod1.c (thus, most cases have separate files
>> > for 32-bit and 64-bit, while x86_64 has a single file containing
>> > definitions for both 64-bit and x32 with one of the macros having an
>> > unconditional definition and the others being conditional).
>> >
>> > Tested x86 and x86_64.  Could architecture maintainers test / review
>> > the changes for other architectures?
>> 
>> Tested on powerpc32 and powerpc64 and no new regressions were observed.
> 
> Thanks.  I think this now just needs sparc testing / review.

I'll take care of this today.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]