This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch for x86_32: Fix bug 14195

From: Carlos O'Donell <carlos_odonell at mentor dot com>
To: Dmitrieva Liubov <liubov dot dmitrieva at gmail dot com>
Cc: <libc-alpha at sourceware dot org>
Date: Fri, 10 Aug 2012 09:03:20 -0400
Subject: Re: Patch for x86_32: Fix bug 14195
References: <CAHjhQ92+Ofq_RXG-uN84oDYkjwv8RQ95LEjgT+nz=JbFiRFkMQ@mail.gmail.com>

On 8/10/2012 8:41 AM, Dmitrieva Liubov wrote:
> This patch fixes bug http://sourceware.org/bugzilla/show_bug.cgi?id=14195
> 
> ChangeLog:
> 
> 2012-08-10  Liubov Dmitrieva  <liubov.dmitrieva@gmail.com>
> 
>         * sysdeps/i386/i686/multiarch/strcmp-sssse3.S: Update
>         Fix bug 14195
>

Does the testsuite catch this?

If it doesn't, could you please add a case which will prevent this from 
regressing in the future?

Comparing two empty strings seems like a corner-case we should be testing.

Cheers,
Carlos.
-- 
Carlos O'Donell
Mentor Graphics / CodeSourcery
carlos_odonell@mentor.com
carlos@codesourcery.com
+1 (613) 963 1026

References:
- Patch for x86_32: Fix bug 14195
  - From: Dmitrieva Liubov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]