This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [BZ #14090] Fix md5/sha512 with large block sizes
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Andreas Jaeger <aj at suse dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Wed, 15 Aug 2012 11:00:20 -0700 (PDT)
- Subject: Re: [BZ #14090] Fix md5/sha512 with large block sizes
- References: <hor4ryd5lc.fsf@byrd.suse.de><20120726205214.777E22C107@topped-with-meat.com><50125297.80904@suse.com><20120727164210.4DE912C105@topped-with-meat.com><5012EAF3.1040108@suse.com><502BDFCE.5020406@suse.com>
> +// MD5 sum values of zero-filled blocks of specified sizes.
We don't use // comments.
> +static struct test_data_s
Add const.
> + else
> + __md5_process_bytes (buf, len, &ctx);
Indentation looks wrong.
> + /* This test will not work with 32-bit size_t, so let it succeed there. */
> + if (sizeof (void *) == 4)
> + return 0;
> +
> + buf = mmap (0, CONST_10G, PROT_READ, MAP_ANONYMOUS | MAP_PRIVATE, -1, 0);
Does this compile without warning on 32-bit machines?
> --- a/crypt/sha512.c
> +++ b/crypt/sha512.c
There's no test for the sha512 change. I don't recall, was it determined
that there is no test that runs in a reasonable time?
Thanks,
Roland