This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PowerPC: Add Program Priority Register support

Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:

> +  ret4 = !(medlow_ppr_before == medlow_ppr_after);
> +
> +  return ret1 && ret2 && ret3 && ret4;

Shouldn't that be ret1 || ret2 || ret3 || ret4?
So that do_test returns 0=success only if all subtests succeeded. 
(Could also rename the variables to make it clearer which value
means success.)
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]