This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] PowerPC: Add Program Priority Register support
On 08/15/2012 06:47 PM, Kalle Olavi Niemitalo wrote:
> Adhemerval Zanella <azanella@linux.vnet.ibm.com> writes:
>
>> + ret4 = !(medlow_ppr_before == medlow_ppr_after);
>> +
>> + return ret1 && ret2 && ret3 && ret4;
> Shouldn't that be ret1 || ret2 || ret3 || ret4?
> So that do_test returns 0=success only if all subtests succeeded.
> (Could also rename the variables to make it clearer which value
> means success.)
>
Indeed you are correct, which showed me an wrong 'fix' I did for this
patch. Working and this and thanks.
--
Adhemerval Zanella Netto
Software Engineer
Linux Technology Center Brazil
Toolchain / GLIBC on Power Architecture
azanella@linux.vnet.ibm.com / azanella@br.ibm.com
+55 61 8642-9890