This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Re: Testsuite races -- updated

On 08/17/2012 11:20 AM, Roland McGrath wrote:
[ ... ]
Thanks for the feedback. This version should address all the issues you raised.


You can't use $$ like this in make rules.  Each line runs in its own shell,
so the two expansions aren't the same.  There is no need to use a uniquely
named temporary file in this sort of case.  When we're considered with
atomic supersede, we use $@T and "mv -f $@T $@".
I can't see why we're creating the datafile, then moving it into place
as separate steps in this code to begin with. ISTM we should just have msgfmt put the bits were they belong.

Thanks again,
Jeff

Attachment: patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]