Re: [PATCH] Re: Testsuite races -- updated

[Jeff Law <law at redhat dot com>]

On 08/17/2012 01:43 PM, Roland McGrath wrote:
> 2. avoid leaving partial output on failure
OK.  Yup, this matters.
> > 2012-08-17  Jeff Law <law@redhat.com>
> >
> > 	* intl/Makefile (codeset_mo): New variable.
> > 	$(codeset_mo): New target.
>
> Missing parens around this.
Fixed.

> > 	(tst-codeset.out): Depend on that.  Remove explicit rule.
> > 	(tst-gettext3.out, tst-gettext5.out): Likewise.
> > 	(LOCPATH-ENV, tst-codeset-ENV): New variables.
> > 	(tst-gettext3-ENV, tst-gettext5-ENV): Likewise.
> > 	* intl/tst-codeset.sh: Remove.
> > 	* intl/tst-gettext3.sh, intl/tst-gettext5.sh: Likewise.
>
> Don't separate file names with a comma.  Use separate lines.
Fixed.

> > +$(codeset_mo):
> > +	$(make-target-directory)
> > +	msgfmt -o $@ tstcodeset.po
>
> Unless you want to examine msgfmt and testify to its inability to leave a
> partial output file on failure, make this $@T with a mv -f command.
Changed to output to $@T, then mv -f into place.

> > +$(objpfx)tst-codeset.out: $(objpfx)tst-codeset $(codeset_mo)
> > +$(objpfx)tst-gettext3.out: $(objpfx)tst-gettext3 $(codeset_mo)
> > +$(objpfx)tst-gettext5.out: $(objpfx)tst-gettext5 $(codeset_mo)
>
> You don't actually need the first dependency here.
> The pattern rule will supply it (and make it first so $< gets it).
Unnecessary dependencies eliminated.

Attachment: patch
Description: Text document