This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: increase timeout on md5test-giant?


On Mon, Sep 17, 2012 at 2:08 PM, Chris Metcalf <cmetcalf@tilera.com> wrote:
> This test is timing out for me on a 1.2 GHz tilegx core.  All the other
> tests pass within the normal timeout limits without having to play with
> $TIMEOUTFACTOR.  As you may recall, this test mmaps a 10 GB area and does
> md5 tests within that region.  I'd like to propose increasing the timeout
> from 180s to 480s, which will capture the tilegx performance of around 6
> minutes with some slack to spare.  I'll push this in a couple of days if I
> don't hear any objections.  Thanks!
>
> 2012-09-17  Chris Metcalf  <cmetcalf@tilera.com>
>
>        * crypt/md5test-giant.c (TIMEOUT): Increase to 8 minutes for tilegx.
>
> diff --git a/crypt/md5test-giant.c b/crypt/md5test-giant.c
> index 6751a2a..63a9c3a 100644
> --- a/crypt/md5test-giant.c
> +++ b/crypt/md5test-giant.c
> @@ -132,6 +132,6 @@ do_test (void)
>  #endif
>
>  /* This needs on a fast machine 90s.  */
> -#define TIMEOUT 180
> +#define TIMEOUT 480
>  #define TEST_FUNCTION do_test ()
>  #include "../test-skeleton.c"

Since this test uses test-skeleton.c you can override the timeout
multiplier in a tile sysdep Makefile, e.g.,

ifeq ($(subdir),crypt)
md5test-giant-ENV = TIMEOUTFACTOR="3"
endif

I believe this would increase the TIMEOUT to 540.

Ryan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]