This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: Cast to _Unwind_Exception_Class when setting exc.exception_class

From: Roland McGrath <roland at hack dot frob dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: GNU C Library <libc-alpha at sourceware dot org>
Date: Tue, 18 Sep 2012 15:01:57 -0700 (PDT)
Subject: Re: PATCH: Cast to _Unwind_Exception_Class when setting exc.exception_class
References: <CAMe9rOpaKE6XxgAev0wzivpSJoL_7-P9VycXnxyankniRZ-FPA@mail.gmail.com><20120918211231.6186A2C0A8@topped-with-meat.com><CAMe9rOp10=Y5u9BhJ6fqTmjYu_roxcXjHcdyUZ=W4XK2wfn71Q@mail.gmail.com><CAMe9rOq064vXtahyYp=UGeRkpwaSQXt14incxerQGJ0C98vcEg@mail.gmail.com>

Andreas correctly points out that it really should have parens, as should
the x86_64 THREAD_SETMEM (which doesn't).  With that change, it's fine.

But I'll note that it really seems like a compiler bug to me that an "A"
constraint would ever fail to set %edx.  (Not that I expect it to be fixed.)


Thanks,
Roland

Follow-Ups:
- Re: PATCH: Cast to _Unwind_Exception_Class when setting exc.exception_class
  - From: H.J. Lu

References:
- PATCH: Cast to _Unwind_Exception_Class when setting exc.exception_class
  - From: H.J. Lu
- Re: PATCH: Cast to _Unwind_Exception_Class when setting exc.exception_class
  - From: Roland McGrath
- Re: PATCH: Cast to _Unwind_Exception_Class when setting exc.exception_class
  - From: H.J. Lu
- Re: PATCH: Cast to _Unwind_Exception_Class when setting exc.exception_class
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]