This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [BZ #10631] Clarify malloc error diagnostics to avoidconfusion


On Tue, Sep 18, 2012 at 03:14:13PM -0400, Carlos O'Donell wrote:
> Old string example:
> *** glibc detected *** ./a.out: free(): invalid next size (fast): 0x084ed538 ***
> 
> New string example:
> *** glibc has detected an error in ./a.out: free(): invalid next size (fast): 0x084ed538 ***
> 
> It now says:
> * Who detected the error? glibc detected the error.
> * What had the error? The application had the error.
> 
> We should also quote the application name and error message e.g.
> 
> *** glibc has detected an error in [./a.out], the error is: [free(): invalid next size (fast)]: 0x084ed538 ***

Uh, I don't like this very much.  Why not just 
*** error in `./a.out': free(): invalid next size (fast): 0x084ed538 ***

I'd be happy also with just:
*** in ./a.out: free(): invalid next size (fast): 0x084ed538 ***

I really don't need anything else to be in this diagnostics.
I find unnecessary verbosity and characters like [ ] rather
distracting.

	Marek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]