This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #14417] Unlock mutex before going back to waitingfor PI mutexes
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Torvald Riegel <triegel at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 1 Oct 2012 15:06:24 +0530
- Subject: Re: [PATCH][BZ #14417] Unlock mutex before going back to waitingfor PI mutexes
- References: <20120921195115.2319b183@spoyarek><1348943552.3374.5816.camel@triegel.csb><20121001112156.05223618@spoyarek><1349083595.3374.5872.camel@triegel.csb>
On Mon, 01 Oct 2012 11:26:35 +0200, Torvald wrote:
> Look, I figured that out, obviously. But that is not the point. We
> can make this easier to understand for whoever reads the code.
> As I wrote, and as you wrote too, this relies on your assumptions on
> which errors the syscall might return, and the scheme how they are to
> be handled. That isn't clear until the reader follows most of the
> possible branches. So why not just point out what you intend to do
> right away?
>
OK, I get your point now. I'll fix the comments. I'll add the
assertion for errno other than EAGAIN or ENOSYS as well, so that if
anyone thinks that it does not belong, I could just remove it again
during review.
Thanks,
Siddhesh