This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch][BZ 6530] *printf and incomplete multibyte sequences returns-1 bogusly

From: Jeff Law <law at redhat dot com>
To: "Carlos O'Donell" <carlos_odonell at mentor dot com>
Cc: libc-alpha <libc-alpha at sourceware dot org>
Date: Mon, 01 Oct 2012 14:40:56 -0600
Subject: Re: [Patch][BZ 6530] *printf and incomplete multibyte sequences returns-1 bogusly
References: <5065EF1E.4020807@redhat.com> <5065FC68.1070206@mentor.com>

On 09/28/2012 01:37 PM, Carlos O'Donell wrote:

On 9/28/2012 2:40 PM, Jeff Law wrote:

I've reviewed Andreas S.'s patch (as has Jonathan Nieder) and it's
also the same patch that Rich Felker submitted (as far as I can tell
independently).  I've also reviewed Jonathan's testsuite addition.

Based on the above, I'm approving and installing these changes to fix
this ANSI compliance issue.

If anyone thinks I'm overstepping here, please let me know.


You are not overstepping your bounds. There is quite a bit of consensus
that the existing code is wrong and that we need to change this.

However, you still need to follow the normal contribution checklist
requirements.

Please post the patch, testing notes, and testcase to the list for
final review.

Sorry, given the patch & testcase had already been posted and were also referenced in the BZ entry, I didn't realize it was necessary to post them again.

I'll take care of it momentarily.

Jeff

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]