Re: [PATCH v2] nscd: fix compilation flags

[Mike Frysinger <vapier at gentoo dot org>]

On Tuesday 02 October 2012 15:22:37 Dmitry V. Levin wrote:
> Commit 61653dfb81b776bb72ce4304175b861d77c357a8 added support for
> compilers predefining _FORTIFY_SOURCE by adding -U_FORTIFY_SOURCE to
> CPPFLAGS for these compilers, but that change doesn't work quite well in
> case of nscd: its Makefile sets _FORTIFY_SOURCE using CFLAGS instead of
> CPPFLAGS and, thanks to compilation rules defined in Makerules, CPPFLAGS
> are passed to compiler after CFLAGS, resulting to a build with
> _FORTIFY_SOURCE turned off.
> 
> This change implements a more safe method of passing preprocessor and
> compiler flags so that no nscd modules could be accidentally forgotten.

nice ... LGTM
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.