This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2][BZ #14417] Unlock mutex before going back to waitingfor PI mutexes


On 10/03/2012 11:40 AM, Siddhesh Poyarekar wrote:
On Wed, 03 Oct 2012 11:25:48 -0600, Jeff wrote:
This looks good.  My brain is hurting from reading too much assembly
code today.  It kept looking to me like the pi-requeued flag as
uninitialized in the i386 versions, but that was an artifact of
mostly looking at the diffs.  Once I referred back to the original it
was pretty obvious what was happening.

FWIW, I haven't seen any complaints since this went into rawhide.

Thanks, I'll check this in on Friday if there are no objections till then. As for the question of whether or not to abort, we could take it up as a separate issue since there will have to be similar validation for the normal FUTEX_WAIT.
Taking it up as a separate discussion seems like the right thing to do.

In GCC-land we have the ability to ask for different levels of checking at configure time. They're broken out into functional areas as well as based on their expense. Perhaps we could do something similar in glibc.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]