This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Link dynamic tests with newly built glibc


On Wed, 10 Oct 2012, H.J. Lu wrote:

> diff --git a/elf/tst-pathopt.sh b/elf/tst-pathopt.sh
> index 048c612..4579885 100755
> --- a/elf/tst-pathopt.sh
> +++ b/elf/tst-pathopt.sh
> @@ -20,7 +20,7 @@
>  set -e
>  
>  common_objpfx=$1
> -run_program_prefix=$2
> +test_program_prefix=$2

This looked odd, because there's no corresponding makefile change - 
actually this test isn't using run_program_prefix at all, and it isn't 
passed down to the shell script.  So changing the name of an unused 
variable doesn't make sense (either remove the variable, or don't change 
it).

Other than that I have no more comments on the handling of individual 
dynamically linked tests, though the whole patch could still do with 
someone else looking at it, especially the generic changes to various 
makefile variables.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]