This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: PATCH: Use unsigned long int in __bswap_64 for __WORDSIZE == 64
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Thu, 11 Oct 2012 10:15:20 -0700 (PDT)
- Subject: Re: PATCH: Use unsigned long int in __bswap_64 for __WORDSIZE == 64
- References: <20121011124402.GA2085@gmail.com>
> 2012-10-09 H.J. Lu <hongjiu.lu@intel.com>
>
> * sysdeps/x86/bits/byteswap.h [__WORDSIZE == 64](__bswap_64):
> Use unsigned long int for GCC >= 4.2.
This should look like:
* sysdeps/x86/bits/byteswap.h [__GNUC_PREREQ (4, 2)]
[__WORDSIZE == 64] (__bswap_64): New implementation, uses
'unsigned long int' rather than 'unsigned long long int'
in argument and return types.
It's still my preference to define a macro for the type and just
change all the appearances of either 'unsigned long long' or
'unsigned long' in this file to use that macro.
Thanks,
Roland