This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH siddhesh/wait_bitset] Use FUTEX_WAIT_BITSET for pthread_cond_timedwaitfor non-x86: ppc, s390

On 10/26/2012 04:19 AM, Siddhesh Poyarekar wrote:
Hi,

Sorry, there was a bug in my patch in the clockbit condition that I had
fixed during testing but forgot to bring back into the patch during
submission.  Here's an updated patch in which everything else is the
same except for the flipped condition for clockbit.  Verified once
again on powerpc and s390.

Also coming up shortly is another patch with a similar change for
pthread_rwlock_timed*lock and __lll_robust_timedlock_wait.

Regards,
Siddhesh

nptl/ChangeLog:

	* pthread_cond_timedwait.c (__pthread_cond_timedwait): Time out
	if absolute timeout is negative.
	[__ASSUME_FUTEX_CLOCK_REALTIME &&
	lll_futex_timed_wait_bitset]: Use lll_futex_timed_wait_bitset.
	* sysdeps/unix/sysv/linux/powerpc/lowlevellock.h
	(lll_futex_timed_wait_bitset): New macro.
	* sysdeps/unix/sysv/linux/s390/lowlevellock.h
	(lll_futex_timed_wait_bitset): Likewise.
Presumably there's some reason why you couldn't use the INTERNAL_SYSCALL mechanisms for the s390 lll_futex_timed_wait_bitset?


Jeff

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]