This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Powerpc/trampline: consider __NO_FPRS__
- From: "Ryan S. Arnold" <ryan dot arnold at gmail dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: Sebastian Andrzej Siewior <sebastian at breakpoint dot cc>, libc-alpha at sourceware dot org
- Date: Thu, 1 Nov 2012 16:56:28 -0500
- Subject: Re: [PATCH] Powerpc/trampline: consider __NO_FPRS__
- References: <20100618083214.GB5851@Chamillionaire.breakpoint.cc><AANLkTimKnCKmuVc2yEHf0ZvDueNdDUMMPejznOOca7ud@mail.gmail.com><Pine.LNX.4.64.1210252107010.30538@digraph.polyomino.org.uk><CAAKybw8E5jh5KpNxHDeYxDVnPotASHDqkxJENT7No+m4S29PSQ@mail.gmail.com><Pine.LNX.4.64.1210312156130.31881@digraph.polyomino.org.uk>
On Wed, Oct 31, 2012 at 4:57 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Wed, 31 Oct 2012, Ryan S. Arnold wrote:
>
>> I'm fine with this now. I'll see if the patch still applies, and if
>> not, I'll forward port and commit. Joseph, were you able to test it
>> with a no-fp toolchain?
>
> I've tested it for no-fp in the past, but not recently. I expect to do
> no-fp testing after the 2.17 freeze and try to understand / resolve
> whatever test failures are then seen for powerpc-nofpu.
>
> --
> Joseph S. Myers
> joseph@codesourcery.com
The addition of guards isn't legally significant.
I tested with default 32-bit (and 64-bit for good measure) builds and
pushed upstream in:
commit a2421a6853085c723d0d611e3bd398bc41b992f6
Author: Sebastan Andrzej Siewior <bigeasy@linutronix.de>
Date: Thu Nov 1 16:48:47 2012 -0500
Put __NO_FPRS__ around floating point opcodes in powerpc32/dl-trampoline.S.
Ryan S. Arnold