This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Add ldconfig cache tag handling for AArch64
On Wed, Nov 14, 2012 at 8:52 PM, Steve McIntyre
<steve.mcintyre@linaro.org> wrote:
> Hi folks,
>
> Initial core code for AArch64 - allocate a tag number
> FLAG_AARCH64_LIB64 and add code to handle it in ldconfig. Code to
> follow on libc-ports to handle parsing ELF flags and using the new
> tag. Follows on from the previous armhf patch in the same area.
>
> =====================================================================
Some of the same nits I mentioned with your other patch apply here,
repeated for the sake of posterity.
Does this change potentially impact other distributions?
> Add ldconfig cache tag handling for AArch64
>
> * sysdeps/generic/ldconfig.h (FLAG_AARCH64_LIB64): New macro.
> * elf/cache.c (print_entry): Print appropriate message for cache
> entries tagged with FLAG_AARCH64_LIB64.
Overly verbose. Suggest `Print ",64bit" for FLAG_AARCH64_LIB64.'
> ---
> ChangeLog | 6 ++++++
> elf/cache.c | 3 +++
> sysdeps/generic/ldconfig.h | 1 +
> 3 files changed, 10 insertions(+)
>
> diff --git a/ChangeLog b/ChangeLog
> index 962a2a7..af56a8f 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,5 +1,11 @@
> 2012-11-15 Steve McIntyre <steve.mcintyre@linaro.org>
>
> + * sysdeps/generic/ldconfig.h (FLAG_AARCH64_LIB64): New macro.
> + * elf/cache.c (print_entry): Print appropriate message for cache
> + entries tagged with FLAG_AARCH64_LIB64.
> +
> +2012-11-15 Steve McIntyre <steve.mcintyre@linaro.org>
> +
> * sysdeps/generic/ldconfig.h (FLAG_ARM_HFABI): New macro.
> * elf/cache.c (print_entry): Print appropriate message for cache
> entries tagged with FLAG_ARM_HFABI.
Don't include ChangeLog in diff.
> diff --git a/elf/cache.c b/elf/cache.c
> index 49aa9a6..e8a4724 100644
> --- a/elf/cache.c
> +++ b/elf/cache.c
Update and merge copyright years.
> @@ -97,6 +97,9 @@ print_entry (const char *lib, int flag, unsigned int osversion,
> case FLAG_ARM_HFABI:
> fputs (",hard-float", stdout);
> break;
> + case FLAG_AARCH64_LIB64:
> + fputs (",64bit", stdout);
> + break;
> case 0:
> break;
> default:
> diff --git a/sysdeps/generic/ldconfig.h b/sysdeps/generic/ldconfig.h
> index 1cffdc6..8e382ff 100644
> --- a/sysdeps/generic/ldconfig.h
> +++ b/sysdeps/generic/ldconfig.h
Update and merge copyright years.
> @@ -35,6 +35,7 @@
> #define FLAG_MIPS64_LIBN64 0x0700
> #define FLAG_X8664_LIBX32 0x0800
> #define FLAG_ARM_HFABI 0x0900
> +#define FLAG_AARCH64_LIB64 0x0A00
>
> /* Name of auxiliary cache. */
> #define _PATH_LDCONFIG_AUX_CACHE "/var/cache/ldconfig/aux-cache"
> --
Cheers,
Carlos.