This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [BZ #13952] Correct L10n of country-name and lang-name in km_KH


On Thu, Nov 15, 2012 at 11:13 AM, Andreas Jaeger <aj@suse.com> wrote:
>
> From bugzilla:
> Country-name field of LC_ADDRESS should be "Cambodia" in Khmer, not "Laos"
> in
> Lao.
> lang_name field of LC_ADDRESS should be "Khmer" in Khmer, not "Laos" in Lao.
>
> Fixed with the appended patch. The change has been confirmed according
> to bugzilla by the GNOME Khmer Team.
>
> Ok to commit?

Yes, with two nits.

> Andreas
>
> 2012-11-15  Chris Leonard  <cjlhomeaddress@gmail.com>
>
>         [BZ #13952]
>         * locales/km_KH: Correct country-name and lang-name.

Many thanks for including the UTF-8 chars in the comments, they made it
easy to do a quick double-check of the <U*> values to make sure it seemed
sensible. It also allows for a triple check against Khmer names in wikipedia
for Khmer and Cambodia.

> diff --git a/localedata/locales/km_KH b/localedata/locales/km_KH
> index 488e53a..d9711aa 100644
> --- a/localedata/locales/km_KH
> +++ b/localedata/locales/km_KH
> @@ -1888,7 +1888,8 @@ postal_fmt
> "<U0025><U0066><U0025><U004E><U0025><U0061><U0025><U004E>/
>  <U0025><U0074><U0025><U0062><U0025><U004E><U0025><U0068><U0025><U0074>/
>  <U0025><U0073><U0025><U004E><U0025><U0054><U0025><U004E><U0025><U0053>/
>  <U0025><U004E><U0025><U007A><U0025><U0063><U0025><U004E>"
> -country_name  "<U0EA5><U0EB2><U0EA7>"
> +% ááááááá

Add "(Kampuchea)" after ááááááá, since that is the english form of the name
and will help future non-Khmer reviewers.

I don't know how kosher it is to use a shortened country name in the
locale, but it's better than being incorrect.

> +country_name "<U1780><U1798><U17D2><U1796><U17BB><U1787><U17B6>"

Verified OK.

>  %FIXME
>  %country_post  ""
>  country_ab2   "<U004C><U0041>"
> @@ -1897,7 +1898,8 @@ country_num   418
>  country_car   "<U004C><U0041><U004F>"
>  %FIXME
>  %country_isbn  ""
> -lang_name     "<U0EA5><U0EB2><U0EA7>"
> +% ááááááááá

Add " (Khmer)" after ááááááááá, since that is the english form of the name
and will help future non-Khmer reviewers.

> +lang_name "<U1797><U17B6><U179F><U17B6><U1781><U17D2><U1798><U17C2><U179A>"

Verified OK.

>  lang_ab       "<U006C><U006F>"
>  lang_term     "<U006c><U0061><U006F>"
>  lang_lib      "<U006C><U0061><U006F>"
> --
> 1.7.0.4

OK to checkin with two new english comment additions.

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]