This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h
- From: Andreas Jaeger <aj at suse dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org,David Holsgrove <david dot holsgrove at xilinx dot com>,libc-ports at sourceware dot org, John Williams <john dot williams at xilinx dot com>,"Edgar E. Iglesias" <edgar dot iglesias at gmail dot com>,Vinod Kathail <vinod dot kathail at xilinx dot com>,Tom Shui <tom dot shui at xilinx dot com>,Vidhumouli Hunsigida <vidhumouli dot hunsigida at xilinx dot com>,Nagaraju Mekala <nagaraju dot mekala at xilinx dot com>
- Date: Thu, 29 Nov 2012 09:04:39 +0100
- Subject: Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h
- References: <CAM=EW8Y-tqvbZwtewup6UagcgJiHEtDmapEmoiR7ZW0SW_-pCg@mail.gmail.com> <50B70BC6.5020502@suse.com> <201211290258.36850.vapier@gentoo.org>
On 11/29/2012 08:58 AM, Mike Frysinger wrote:
On Thursday 29 November 2012 02:16:22 Andreas Jaeger wrote:
On 11/29/2012 06:28 AM, David Holsgrove wrote:
+#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */
+#define EM_MICROBLAZE 0xbaab
Are any of these official values? The comment above asks for hig numbers
and 0xbd is not height.
the first one is, but should be renamed. from binutils:
#define EM_MICROBLAZE 189 /* Xilinx MicroBlaze 32-bit RISC soft processor core */
In that case, it should be sorted at the proper place - directly after
EM_TILEPRO.
David, we've just frozen glibc for development, these kind of patches
are too late for glibc 2.17. Please update them and they will get
properly reviewed and added once 2.17 is released.
Btw. do you have copyright announcement with the FSF?
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126