This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] settimeofday with NULL tv

From: Jeff Law <law at redhat dot com>
To: David Miller <davem at davemloft dot net>
Cc: libc-alpha at sourceware dot org
Date: Mon, 03 Dec 2012 12:17:49 -0700
Subject: Re: [PATCH] settimeofday with NULL tv
References: <50BCF7A8.9060300@redhat.com> <20121203.141330.2120798408893308961.davem@davemloft.net>

On 12/03/2012 12:13 PM, David Miller wrote:

From: Jeff Law <law@redhat.com>
Date: Mon, 03 Dec 2012 12:04:08 -0700


settimeofday (NULL, tz) is used by systemd (and perhaps other code) to
change the kernel timezone.  Unfortunately, glibc marks the first
argument as must-be-nonnull.  This causes static analyzers to issue
incorrect diagnostics for such uses of settimeofday.

This patch removes the __nonnull attribute and the bogus diagnostics
no longer are issued.

This looks fine to me.

Installed.  Thanks.
jeff

References:
- [PATCH] settimeofday with NULL tv
  - From: Jeff Law
- Re: [PATCH] settimeofday with NULL tv
  - From: David Miller

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]