This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] linux: posix_fadvise: support __NR_fadvise64_64


On Thursday 06 December 2012 16:35:33 Carlos O'Donell wrote:
> On Thu, Dec 6, 2012 at 3:06 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > From: Carlos O'Donell <carlos_odonell@mentor.com>
> > 
> > Some arches do not have a __NR_fadvise64 but do have __NR_fadvise64_64.
> > If the former is unavailable, fallback to the latter.
> > 
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> 
> Reviewed-by: Carlos O'Donell <carlos@systemhalted.org>
> 
> > 2012-12-06  Carlos O'Donell  <carlos_odonell@mentor.com>
> > 
> >             Mike Frysinger  <vapier@gentoo.org>
> >         
> >         * sysdeps/unix/sysv/linux/posix_fadvise.c (posix_fadvise): Also
> >         check for __NR_fadvise64_64.
> 
> This is strictly a bug fix and should be OK for master right now.
> 
> It also doesn't change the generated code for any working machines.
> 
> This looks good to me and fixes fadvise on hppa where we have only
> fadvise64_64.
> 
> OK to checkin with copyright year update.

done and done
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]