This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #6885] Clarify description of __freading and __fwriting
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 13 Dec 2012 07:28:32 -0800 (PST)
- Subject: Re: [PATCH][BZ #6885] Clarify description of __freading and __fwriting
- References: <20121213130709.GA29577@spoyarek.pnq.redhat.com>
> The patch below makes the descriptions of __freading and __fwriting a
> bit clearer. OK to commit (I assume after the freeze is lifted)?
I think it's probably fine to do changes to the manual during the freeze,
assuming you verify that it still formats correctly. But it's up to Dave.
> +The @code{__freading} function returns a nonzero value if the stream
> +@var{stream} was last read from or is opened read-only. Otherwise the function
"was opened"
> +returns zero. Determining whether a stream opened for reading and writing was
> +last used for writing allows to draw conclusions about the content about the
> buffer, among other things.
"allows one to draw" or "makes it possible to draw"
"the contents of the buffer"
> +The @code{__fwriting} function returns a nonzero value if the stream
> +@var{stream} was last written to or is opened write-only. Otherwise the
> +function returns zero.
"or was opened"
These still don't really give any clarity about why you'd ever use these
functions. But it is an improvement from the old text anyway. I don't
think it's really any clearer, but it is in much more natural English.
Thanks,
Roland