This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 04/15] Convert pthread_rwlock_try(rd/wr)lock to prototypes

On Fri, Dec 28, 2012 at 01:08:31PM +0100, Andreas Jaeger wrote:
> On 12/23/2012 04:02 AM, Andi Kleen wrote:
> >From: Andi Kleen <ak@linux.intel.com>
> >
> >Later patches include these files in sysdeps, and the sysdeps sub Makefiles
> >make the compiler complain about non prototype functions. So change
> >them to prototypes.
> >
> >2012-12-09    <ak@linux.intel.com>
> >
> >         * nptl/pthread_rwlock_tryrdlock.c (__pthread_rwlock_tryrdlock):
> >         Conver to prototype.
> 
> Typo: convert.
> >         * nptl/pthread_rwlock_trywrlock.c (__pthread_rwlock_trywrlock): 
> >         Dito.
> 
> We normally use Likewise instead of Dito.
> 
> The patch itself is fine.
> 
> Andi, shall I commit it for you?

Yes please.

-Andi
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]