This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: <netinet/tcp.h> sync with Linux?


POSIX.1-2008 specifies netinet/tcp.h and says that it can define any TCP_*
symbol but no others.  It wasn't completely obvious from the diff alone
that the other symbols (tcp_* types) you added were inside __USE_MISC.

I'm all for whitespace canonicalization to tabs, but including that in a
patch doing other things makes it harder to read and review.  When that
issue exists, posting an addition patch made with -b makes it easier.
But what's really easiest for everybody IMHO is if you nearly always
push a private git branch with your change, so we can look at diffs
ourselves with whatever tools and options we like.

The new enum values and types really need some comments.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]