Re: [PATCH 3/3] manual: glob flags: fix sorting order

[Carlos O'Donell <carlos at systemhalted dot org>]

On 12/21/2012 12:04 AM, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Reviewed-by: Carlos O'Donell <carlos@systemhalted.org>

It is obviously correct to me that the constants should
be sorted alphabetically to make finding them easier.

Please check this in immediately.

> 
> 2012-12-20  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* manual/pattern.texi (Flags for Globbing): Move GLOB_NOSORT after
> 	GLOB_NOESCAPE.
> ---
>  manual/pattern.texi | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/manual/pattern.texi b/manual/pattern.texi
> index 60e9dc8..1966f3f 100644
> --- a/manual/pattern.texi
> +++ b/manual/pattern.texi
> @@ -495,13 +495,6 @@ matches.)
>  
>  @comment glob.h
>  @comment POSIX.2
> -@item GLOB_NOSORT
> -Don't sort the file names; return them in no particular order.
> -(In practice, the order will depend on the order of the entries in
> -the directory.)  The only reason @emph{not} to sort is to save time.
> -
> -@comment glob.h
> -@comment POSIX.2
>  @item GLOB_NOESCAPE
>  Don't treat the @samp{\} character specially in patterns.  Normally,
>  @samp{\} quotes the following character, turning off its special meaning
> @@ -514,6 +507,13 @@ If you use @code{GLOB_NOESCAPE}, then @samp{\} is an ordinary character.
>  @code{glob} does its work by calling the function @code{fnmatch}
>  repeatedly.  It handles the flag @code{GLOB_NOESCAPE} by turning on the
>  @code{FNM_NOESCAPE} flag in calls to @code{fnmatch}.
> +
> +@comment glob.h
> +@comment POSIX.2
> +@item GLOB_NOSORT
> +Don't sort the file names; return them in no particular order.
> +(In practice, the order will depend on the order of the entries in
> +the directory.)  The only reason @emph{not} to sort is to save time.
>  @end vtable
>  
>  @node More Flags for Globbing
> 

Cheers,
Carlos.