This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Adapt installed powerpc headers better for soft-float / no-FPRs
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 14 Jan 2013 16:08:02 -0800 (PST)
- Subject: Re: Adapt installed powerpc headers better for soft-float / no-FPRs
- References: <Pine.LNX.4.64.1301150001000.19709@digraph.polyomino.org.uk>
> +#if !defined _SOFT_FLOAT && !defined __NO_FPRS__
> /* The powerpc has a combined multiply/add instruction. */
> -# define FP_FAST_FMA 1
> -# define FP_FAST_FMAF 1
> +# define FP_FAST_FMA 1
> +# define FP_FAST_FMAF 1
> +#endif
You added the second space to the define lines but omitted the necessary
single space on the if/endif.
> -#if defined __GNUC__ && !defined _SOFT_FLOAT && !defined __NO_MATH_INLINES
> +#if defined __GNUC__ && !defined _SOFT_FLOAT && !defined __NO_FPRS__ \
> + && !defined __NO_MATH_INLINES
Please use parens in such cases so the indentation is coherent.
Thanks,
Roland