This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Fix SHLIB_COMPAT with undefined obsoleting version


nptl/old_pthread_atfork.c uses SHLIB_COMPAT (libpthread, GLIBC_2_0,
GLIBC_2_3), but Versions.def has no GLIBC_2.3 entry for libpthread (it
didn't get a new symbol in that version).  This means that this
expression is always true, and the compat symbol is included even for
platforms that are newer than GLIBC_2.3 (eg. x32, aarch64; powerpc64 has
GLIBC_2.3 as its earliest symbol set, which causes
ABI_libpthread_GLIBC_2_3 to be defined, so it doesn't suffer from this
bug).

Andreas.

	* Versions.def (libpthread): Add GLIBC_2.3, so that it can be used
	by SHLIB_COMPAT.

diff --git a/Versions.def b/Versions.def
index 8651992..7c7d1f8 100644
--- a/Versions.def
+++ b/Versions.def
@@ -93,6 +93,7 @@ libpthread {
   GLIBC_2.2
   GLIBC_2.2.3
   GLIBC_2.2.6
+  GLIBC_2.3
   GLIBC_2.3.2
   GLIBC_2.3.3
   GLIBC_2.3.4

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]