This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping: [PATCH v4] faster strlen on x64


On Tue, Mar 12, 2013 at 09:24:07AM -0400, Carlos O'Donell wrote:
> On 03/11/2013 05:15 AM, OndÅej BÃlka wrote:
> > Carlos, what is you opinion?
> 
> The patch looks good. I have one last question though.
> 
> We remove some interesting code in the existing strlen implementations
> that ensure that strlen calls from libc itself do not go through the PLT.
> 
> Have you verified that after your changes there are no testsuite regressions
> in the plt check test or that the internal calls to strlen avoid the PLT?
> 
> OK to checkin after this additional validation with posted result.
> 

I ran http://sourceware.org/glibc/wiki/Testing/Check-localplt 
elf/checklocalplt.out is empty. I guess this means no regressions.

Ondra.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]