This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Pushing a git note fails.
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Jim Meyering <jim at meyering dot net>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, Mike Frysinger <vapier at gentoo dot org>
- Date: Sat, 06 Apr 2013 17:59:38 -0400
- Subject: Re: Pushing a git note fails.
- References: <51604CF5 dot 3010707 at redhat dot com> <87vc7z61nk dot fsf at rho dot meyering dot net> <516058D7 dot 60500 at redhat dot com>
On 04/06/2013 01:18 PM, Carlos O'Donell wrote:
>> diff --git a/update b/update
>> index ed76bd2..f5385a0 100755
>> --- a/update
>> +++ b/update
>> @@ -171,6 +171,9 @@ case "$refname","$newrev_type" in
>> exit 1
>> fi
>> ;;
>> + refs/notes/*,*)
>> + # Notes: no restrictions.
>
> Would this allow other users to create new notes namespaces?
>
> I hope that it does, since that would also be useful.
>
>> + ;;
>> *)
>> # Anything else (is there anything else?)
>> echo "*** Update hook: unknown type of update to ref $refname of type $newrev_type" >&2
>>
>
> Your changes look fine to me.
Thanks! It looks like my notes were pushed.
[carlos@koi glibc]$ git push origin refs/notes/*
Counting objects: 3, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 331 bytes, done.
Total 3 (delta 0), reused 0 (delta 0)
remote: *** Unknown type of update to refs/notes/commits (commit)
remote: *** - no email generated
To ssh://carlos@sourceware.org/git/glibc.git
* [new branch] refs/notes/commits -> refs/notes/commits
[carlos@koi glibc]$
Is there anything we can do about generating an email?
Cheers,
Carlos.